Fix EOFError in non-interactive init flows#2162
Merged
Merged
Conversation
mashraf-222
requested review from
HeshamHM28 and
Saga4
and removed request for
misrasaurabh1
Author
|
Clarification on the intended behavior here:
So this PR is not removing the existing prompt UX; it only makes the no-stdin path fail safe instead of fail noisy. |
Author
eof.fix.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
initconfirmation prompts by falling back to safe defaults instead of raisingEOFErrorinitruns without interactive stdinTested
uv run pytest -q tests/test_init_yes.py tests/test_init_javascript.py tests/test_init_java_go.py tests/test_github_workflow.pyinitruns with empty stdin in Python, JavaScript, TypeScript, Java, and Go sample repos